Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the pre-receive hook template into a separate file #87

Closed
arschles opened this issue Jan 7, 2016 · 5 comments
Closed

move the pre-receive hook template into a separate file #87

arschles opened this issue Jan 7, 2016 · 5 comments
Assignees
@arschles
Labels
enhancement

Comments

@arschles
Copy link
Member

arschles commented Jan 7, 2016

Do this after #72.

Have pkg/git/git.go parse the template file (use the existing template.Must) and execute it directly into the new file (instead of bytes.Buffer => io.WriteFile)
@arschles arschles added this to the v2.0-beta1 milestone Jan 7, 2016
arschles pushed a commit to arschles/deis-builder that referenced this issue Jan 14, 2016
ref(git.go,pre-receive.tpl): move pre-receive hook script into a temp…
bfbb985 
…late on the filesystem

Fixes deis#87
@arschles arschles mentioned this issue Jan 14, 2016
Closed
@arschles arschles self-assigned this Jan 14, 2016
@technosophos
Copy link
Member

I believe we can ship without this, right? Can we pull this off of the beta milestone?

@smothiki
Copy link
Contributor

This is no longer relevant as git receive is no longer using any shell script

@slack slack removed the in progress label Feb 24, 2016
@smothiki
Copy link
Contributor

My bad this issue is still present reopening but removing beta tag

@smothiki smothiki reopened this Feb 24, 2016
@smothiki smothiki modified the milestones: v2.0-rc1, v2.0-beta1 Feb 24, 2016
@arschles
Copy link
Member Author

Just to confirm, yes we can pull off the milestone. @smothiki thanks for leaving open

Sent from my iPhone

On Feb 24, 2016, at 12:14, Sivaram Mothiki notifications@github.com wrote:

Reopened #87.

—
Reply to this email directly or view it on GitHub.

@smothiki smothiki modified the milestones: v2.0, v2.0-rc1 May 23, 2016
@slack slack removed this from the v2.0 milestone Jun 3, 2016
@Joshua-Anderson
Copy link
Contributor

This was fixed in #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arschles arschles

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@slack @arschles @technosophos @Joshua-Anderson @smothiki