Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(probes): move k8s probe from liveness into readiness #334

Closed
wants to merge 0 commits into from

Conversation

kmala
Copy link
Contributor

@kmala kmala commented May 11, 2016

Summary of Changes

add probe to check the status of the controller

Issue(s) that this PR Closes

Closes #181

Associated End To End Test PR(s)

Associated Documentation PR(s)

Associated Design Document(s)

Testing Instructions

Please provide a detailed list for how to test the changes in this PR.

  1. Create a Deis Cluster
  2. check the status of the builder and it should be serving
  3. now stop the controller and check the status of the builder, it should still be up but not ready to serve requests

Pull Request Hygiene TODOs

Please make sure the below checklist is complete.

  • Your pull request is concise and to the point (make another PR for refactoring nearby code)
  • Your commits are squashed into logical units of work
  • Your commits follow the commit style guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants