-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unconventional labels and selectors #40
Comments
+1. I've checked in a few offending manifests |
I'm going to fix these when I get a minute. @technosophos should these be fixed only in the dev charts? i.e. should we treat the "released" / alpha charts as immutable until we refresh them to reflect the beta release? I think we should update the alpha charts in this particular case since doing so won't affect functionality. |
Although there probably aren't any stragglers after this. Just reassigning this to you. Thanks. |
@krancour judging by comments, I'm the only one to have tested it and I think it'd be good to have others test as well before merge. I'll continue the conversation on the PR |
There are numerous places in the chart's many manifests where labels and selectors such as
name: foo
have been used instead of the more conventionalapp: foo
. This should be corrected.The text was updated successfully, but these errors were encountered: