Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unconventional labels and selectors #40

Closed
krancour opened this issue Dec 15, 2015 · 6 comments
Closed

Fix unconventional labels and selectors #40

krancour opened this issue Dec 15, 2015 · 6 comments
Assignees
Milestone

Comments

@krancour
Copy link
Contributor

There are numerous places in the chart's many manifests where labels and selectors such as name: foo have been used instead of the more conventional app: foo. This should be corrected.

@arschles
Copy link
Member

+1. I've checked in a few offending manifests

@krancour
Copy link
Contributor Author

I'm going to fix these when I get a minute. @technosophos should these be fixed only in the dev charts? i.e. should we treat the "released" / alpha charts as immutable until we refresh them to reflect the beta release? I think we should update the alpha charts in this particular case since doing so won't affect functionality.

@arschles
Copy link
Member

@krancour see #41 for a start on changing the labels

RE your released/alpha question - I agree that we should update alpha charts here

@krancour
Copy link
Contributor Author

Uh. I am a dummy. I totally scrolled right past the cross-reference to #41 above and didn't notice it. Can you merge #41 (it has its LGTMs) and I will go after any stragglers after that?

@krancour
Copy link
Contributor Author

Although there probably aren't any stragglers after this. Just reassigning this to you. Thanks.

@krancour krancour assigned arschles and unassigned krancour Jan 12, 2016
@arschles
Copy link
Member

@krancour judging by comments, I'm the only one to have tested it and I think it'd be good to have others test as well before merge. I'll continue the conversation on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants