Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): use standard app labels & selectors, add heritage label where necessary [WIP] #41

Merged
merged 5 commits into from
Jan 12, 2016
Merged

fix(*): use standard app labels & selectors, add heritage label where necessary [WIP] #41

merged 5 commits into from
Jan 12, 2016

Conversation

arschles
Copy link
Member

This PR changes all manifests to use standard app labels and selectors where appropriate. It also adds heritage labels where they're missing.

Fixes #40

@arschles arschles self-assigned this Dec 16, 2015
@arschles arschles added this to the v2.0-alpha1 milestone Dec 16, 2015
@arschles arschles changed the title fix(*): use standard app labels & selectors, add heritage label where necessary fix(*): use standard app labels & selectors, add heritage label where necessary [WIP] Dec 16, 2015
@bacongobbler
Copy link
Member

(haven't manually tested this, but the code does LGTM)

@technosophos technosophos modified the milestones: v2.0-beta1, v2.0-alpha1 Dec 29, 2015
@technosophos
Copy link
Member

I'd like to wait until after Alpha1 to merge because I am afraid there might be subtle assumptions being made in Alpha1, and I'd like to have a chance to hunt for them.

@arschles
Copy link
Member Author

👍

@arschles arschles mentioned this pull request Dec 31, 2015
Closed
@arschles arschles mentioned this pull request Jan 12, 2016
Closed
@arschles
Copy link
Member Author

(continued from #40)

@krancour judging on comments here, it looks like I'm the only one to have tested this. Can you also test before merge? I want to be paranoid here and make absolutely sure there are no issues that I may not have caught

@krancour
Copy link
Contributor

I'd be happy to.

@arschles
Copy link
Member Author

thanks!

@krancour
Copy link
Contributor

@arschles there are several occurrences within the deis-dev chart that aren't corrected by this PR. They probably should be.

@arschles
Copy link
Member Author

@krancour good to know. fixing now

@arschles
Copy link
Member Author

@krancour fixed and commits pushed. testing deis-dev now, as this PR originally predated that chart

@arschles
Copy link
Member Author

@krancour testing shows that all services in the cluster, when launched from the deis-dev chart, have valid endpoints

@jchauncey
Copy link
Member

I like this change btw. Makes the data in fluentd consistent

@krancour
Copy link
Contributor

@arschles I just finished testing with both deis and deis-dev charts. Looks good. LGTM3

@arschles
Copy link
Member Author

thanks @krancour. merging

arschles added a commit that referenced this pull request Jan 12, 2016
@arschles
Merge pull request #41 from arschles/labels-selectors
47b9f77 
fix(*): use standard app labels & selectors, add heritage label where necessary [WIP]
@arschles arschles merged commit 47b9f77 into deis:master Jan 12, 2016
@arschles arschles deleted the labels-selectors branch January 12, 2016 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arschles arschles

Labels
enhancement LGTM1 LGTM2 needs manual testing
Projects
None yet
Milestone
v2.0-beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@arschles @bacongobbler @technosophos @krancour @jchauncey