ref(e2e): Refactor e2e test charts to complement the refactored test suite #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, reviewers please note I moved these out from under |
|
The readme needs to be updated to reflect the change in the pod name |
|
Nice catch. |
|
Commit has now been amended to remove the |
|
Thanks for the reviews, guys. Will hold off on merging this until deis/workflow-e2e#157 is ready to be merged. |
|
Closes #215 |
vdice
pushed a commit
to vdice/chart-mate
that referenced
this pull request
Apr 12, 2016
This represents the necessary update to go along with changes in deis/workflow-e2e#157 and deis/charts#218
vdice
pushed a commit
to vdice/chart-mate
that referenced
this pull request
Apr 12, 2016
This represents the necessary update to go along with changes in deis/workflow-e2e#157 and deis/charts#218
vdice
pushed a commit
to vdice/chart-mate
that referenced
this pull request
Apr 12, 2016
This represents the necessary update to go along with changes in deis/workflow-e2e#157 and deis/charts#218
vdice
pushed a commit
to vdice/chart-mate
that referenced
this pull request
Apr 12, 2016
This represents the necessary update to go along with changes in deis/workflow-e2e#157 and deis/charts#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #214
Relates to deis/workflow-e2e#157
cc @vdice @arschles