chore(workflow-v2.2.0): releasing workflow-v2.2.0(-e2e) #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| # Deis Router 2.0.0 | |||
There was a problem hiding this comment.
Should be 2.2.0 -- deisrel error you mentioned @smothiki ?
| @@ -0,0 +1,5 @@ | |||
| [e2e] | |||
| org = "deisci" | |||
| dockerTag = "canary" | |||
There was a problem hiding this comment.
this should be tagged to a specific git tag
|
from grokking the chart it appears that there are 18 instances in workflow-v2.2.0 that are using the canary images. We should switch them to git tags. I'm aware that we know this internally, just posting publicly :) |
|
@bacongobbler updated to git tags |
| [minio] | ||
| org = "deisci" | ||
| pullPolicy = "Always" | ||
| dockerTag = "canary" |
|
Fixed |
|
Awesome. Back to testing! |
This was referenced Jul 20, 2016
|
Both @mboersma and I are hanging for a very long time when we attempt to uninstall workflow-v2.2.0 from our cluster: The problem seems to be coming from the reigstry-proxy as everything zips by as soon as it's removed. Total time is ~2 minutes in comparison to the old ~15 seconds. |
|
|
||
| [minio] | ||
| org = "deisci" | ||
| pullPolicy = "Always" |
There was a problem hiding this comment.
This should be changed to:
pullPolicy = "IfNotPresent"
arschles
pushed a commit
to arschles/deis-workflow
that referenced
this pull request
Jul 20, 2016
…arts as discussed at deis/charts#310 (comment), the herein-removed deisrel command for generating new helm charts may have a bug. Since I don’t believe it’s too hard to manually go change the params files, this PR changes instructions to indicate that the files should be manually edited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charts for v2.2.0. Tested by installing deis on v1.2.5 k8s cluster
There are some errors from deisrel which I manually corrected. Please take a closer look before giving LGTM