This repository has been archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
fix(controller): Persist ssl.enforce header on service creation #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
mattk42
force-pushed
the
persist-https-enforcement
branch
from
June 6, 2017 17:48
0b67ef1
to
c81dbf9
Compare
Jenkins, add to whitelist. |
Thanks @mattk42! This needs a rebase and seems to have failed a unit test:
|
ping @mattk42 -- any chance to rebase and potentially fix up test(s)? |
Sorry, lost track of this. Will take a look tonight.
|
mattk42
force-pushed
the
persist-https-enforcement
branch
from
July 4, 2017 15:52
67b87ca
to
c81dbf9
Compare
Thanks @mattk42 ! fyi: e2e actually passed (ran right up to the 30 min timeout, but all specs passed): https://ci.deis.io/job/workflow-chart-e2e/391/console |
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
- Coverage 86.99% 86.88% -0.12%
==========================================
Files 45 45
Lines 3929 3941 +12
Branches 681 682 +1
==========================================
+ Hits 3418 3424 +6
- Misses 339 346 +7
+ Partials 172 171 -1 |
mboersma
approved these changes
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1304