This repository has been archived by the owner on May 6, 2020. It is now read-only.
feat(apps): validate routeability through deis-router upon application creation #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgi
force-pushed
the
ticket_551
branch
3 times, most recently
from
cbdc3e9
to
0bb6716
Compare
Current coverage is
|
helgi
force-pushed
the
ticket_551
branch
6 times, most recently
from
6c4cfcb
to
7a67d3a
Compare
|
Running tests w/ these changes it appears we can now re-enable a few more tests (specifically actions immediately post app deploy). I'll create the correlating PR in workflow-e2e |
…n creation Hits the router IP via python-requests with a Host header (uses xip.io) to emulate a request to the application. Sends a Deis Controller UA to make debugging easier HTTP mocking is required for this to work in tests and all tests now get peppered with mock_requests object, which they can use for other purposes as well if required Depends on a change to the requests_mock python package for testing only, pulling that from git currently Tests take 2x the time because of added timing jitter to emulate router being slow to respond at times Fixes deis#551
| @@ -312,6 +312,7 @@ def __init__(self): | |||
| 'User-Agent': user_agent('Deis Controller', deis_version) | |||
| } | |||
| # TODO: accessing the k8s api server by IP address rather than hostname avoids | |||
| # TODO look at https://toolbelt.readthedocs.org/en/latest/adapters.html#fingerprintadapter | |||
There was a problem hiding this comment.
nit: looks like this TODO interrupts the sentence started above
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hits the router IP via python-requests with a Host header (uses nip.io) to emulate a request to the application. Sends a Deis Controller UA to make debugging easier
HTTP mocking is required for this to work in tests and all tests now get peppered with mock_requests object, which they can use for other purposes as well if required
Depends on a change to the requests_mock python package for testing only, pulling that from git currently
Tests take 2x the time because of added timing jitter to emulate router being slow to respond at times
Fixes #551