docs(README): Add architecture diagram #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @arschles to be a potential reviewer |
jchauncey
force-pushed
the
add-architecture-diagram
branch
2 times, most recently
from
139d20e
to
c5a0a11
Compare
| ▼ │ | ||
| ┌────────┐ ┌─────────┐ │ | ||
| │App Logs│───Log file────▶│ fluentd │──UDP/Syslog | ||
| └────────┘ └─────────┘ │ ┌──────────┐ |
There was a problem hiding this comment.
This diagram indicates that router logs flow somehow into app logs. Is that right? My original assumption was that fluentd consumes both directly
There was a problem hiding this comment.
whoops i didnt catch that. the indentation is off. ill fix it.
|
The diagram LGTM except for #103 (comment). I'm marking LGTM1 assuming you'll address that if applicable |
jchauncey
force-pushed
the
add-architecture-diagram
branch
from
c5a0a11
to
287048e
Compare
| │ HOST │ ┌───────────┐ Wire │ | ||
| │ Telegraf │────┬────▶│ InfluxDB │◀───────Protocol────┘ | ||
| └─────────────┘ │ └───────────┘ | ||
| │ ▲ |
There was a problem hiding this comment.
grafana pulls info from InfluxDB right? (opposite arrow direction?)
There was a problem hiding this comment.
hrm yeah which is why it was weird to have the arrow the other way but i changed it.
jchauncey
force-pushed
the
add-architecture-diagram
branch
from
287048e
to
42f91b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.