-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grafana,telegraf): Pull metric data from nsq via telegraf #110
Conversation
@krancour and @sstarcher are potential reviewers of this pull request based on my analysis of |
@jchauncey looks like you're downloading the telegraf deb and then installing telegraf in the Dockerfile at |
Also updates grafana graphs with correct series names.
@@ -35,6 +35,12 @@ spec: | |||
value: "true" | |||
- name: "ENABLE_PROMETHEUS" | |||
value: "true" | |||
- name: "NSQ_CONSUMER_SERVER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: worth making the prefixes for all these env vars NSQD_
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it so it matches the plugin name. Which is nsq_consumer
@jchauncey the json diffs are a bit hard to parse, but the changed files themselves look ok. my nitpick is not blocking for this PR. Also, thanks for removing the telegraf binary. Code LGTM |
Yeah the json diffs suck. easy way to test it is to build and push the image and check the graphs out |
This PR updates several parts of the monitoring stack to support our move to NSQ. It is in progress for now since we are waiting for telegraf to merge my PR - influxdata/telegraf#1369