Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telegraf): Use the new kubernetes input plugin #147

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

jchauncey
Copy link
Member

@jchauncey jchauncey commented Oct 4, 2016

Allows us to move away from the prometheus endpoint and instead use the local kubelet api

Testing Steps:

  • clone PR
  • cd telegraf
  • IMAGE_PREFIX=<account> make build push upgrade
  • cd grafana
  • IMAGE_PREFIX=<account> make build push upgrade
  • Log into grafana (grafana.mydomain.com) use admin/admin
  • Make sure graphs show CPU data in milli-cores

@jchauncey jchauncey added this to the v2.7 milestone Oct 4, 2016
@jchauncey jchauncey self-assigned this Oct 4, 2016
@jchauncey jchauncey force-pushed the k8s-plugin branch 2 times, most recently from 9c95523 to 69d5cdf Compare October 4, 2016 15:09
template:
metadata:
labels:
app: deis-monitor-grafana
spec:
containers:
- name: deis-monitor-grafana
image: quay.io/deis/grafana:canary
image: quay.io/deis/grafana:v2.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still want this to stay as :canary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make it 2.5.0 but it rarely gets updated and im pretty sure was canary in the old rc manifest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I mean "can you change this back to :canary"? Right now it's pointing at v2.5.0.

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested; looks good! Just one comment.

&& dpkg -i /tmp/telegraf.deb \
&& rm /tmp/telegraf.deb \
&& chmod +x /usr/bin/telegraf \
# && curl -SL -o /tmp/telegraf.deb https://dl.influxdata.com/telegraf/releases/telegraf_1.0.0_amd64.deb \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these lines can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt want to remove these because we will be going back to using the package once they release my new plugin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger; maybe a comment to that effect here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@jchauncey
Copy link
Member Author

Oh dang yeah I'll do that

On Oct 5, 2016 6:19 PM, "Matthew Fisher" notifications@github.com wrote:

@bacongobbler commented on this pull request.

In grafana/manifests/deis-monitor-grafana-deployment.yaml
#147:

template:
metadata:
labels:
app: deis-monitor-grafana
spec:
containers:
- name: deis-monitor-grafana

  •    image: quay.io/deis/grafana:canary
    
  •    image: quay.io/deis/grafana:v2.5.0
    

oh I mean "can you change this back to :canary"? Right now it's pointing
at v2.5.0.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#147, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaRGMHAi8TJeJZev9iWujTtnnrmmjTaks5qxCJJgaJpZM4KNxCy
.

Allows us to move away from the prometheus endpoint and instead use the local kubelet api
@jchauncey jchauncey merged commit 26bbc2d into deis:master Oct 7, 2016
@jchauncey jchauncey deleted the k8s-plugin branch October 7, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants