-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(telegraf): Use the new kubernetes input plugin #147
Conversation
9c95523
to
69d5cdf
Compare
template: | ||
metadata: | ||
labels: | ||
app: deis-monitor-grafana | ||
spec: | ||
containers: | ||
- name: deis-monitor-grafana | ||
image: quay.io/deis/grafana:canary | ||
image: quay.io/deis/grafana:v2.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still want this to stay as :canary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make it 2.5.0 but it rarely gets updated and im pretty sure was canary in the old rc manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I mean "can you change this back to :canary"? Right now it's pointing at v2.5.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested; looks good! Just one comment.
&& dpkg -i /tmp/telegraf.deb \ | ||
&& rm /tmp/telegraf.deb \ | ||
&& chmod +x /usr/bin/telegraf \ | ||
# && curl -SL -o /tmp/telegraf.deb https://dl.influxdata.com/telegraf/releases/telegraf_1.0.0_amd64.deb \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these lines can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didnt want to remove these because we will be going back to using the package once they release my new plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger; maybe a comment to that effect here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Oh dang yeah I'll do that On Oct 5, 2016 6:19 PM, "Matthew Fisher" notifications@github.com wrote:
|
Allows us to move away from the prometheus endpoint and instead use the local kubelet api
Allows us to move away from the prometheus endpoint and instead use the local kubelet api
Testing Steps:
cd telegraf
IMAGE_PREFIX=<account> make build push upgrade
cd grafana
IMAGE_PREFIX=<account> make build push upgrade
grafana.mydomain.com
) use admin/adminmilli-cores