Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telegraf): Allow user to disable disk plugin #154

Closed
wants to merge 1 commit into from

Conversation

jchauncey
Copy link
Member

No description provided.

@jchauncey jchauncey added this to the v2.8 milestone Oct 21, 2016
@jchauncey jchauncey self-assigned this Oct 21, 2016
@deis-bot
Copy link

@sstarcher is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @jchauncey!

@kmala kmala added the LGTM1 label Oct 21, 2016
@sstarcher
Copy link
Contributor

Any reason to not follow the same pattern as everything else by using ENABLE
{{ if .ENABLE_ETCD }}

@jchauncey
Copy link
Member Author

figured out my problem with coreos and disk. Basically there are certain parts of the filesystem that you cant really father stats for. So I just set DISK_MOUNT_POINTS to ["/"]

@jchauncey jchauncey closed this Oct 22, 2016
@jchauncey jchauncey deleted the disable-disk branch October 22, 2016 04:12
@jchauncey
Copy link
Member Author

I want it on by default so made sense to make it implicit without having to
put it in the chart.

On Oct 21, 2016 12:26 PM, "Shane Starcher" notifications@github.com wrote:

Any reason to not follow the same pattern as everything else by using
ENABLE
{{ if .ENABLE_ETCD }}


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#154 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaRGODF5M2Qqz_z356ye5Miew8eNaWlks5q2OeZgaJpZM4KdZOU
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants