Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): add aws-specific idle timeout annotation to router service #327

Merged
merged 1 commit into from
Mar 22, 2017
Merged

feat(chart): add aws-specific idle timeout annotation to router service #327

merged 1 commit into from
Mar 22, 2017

Conversation

vdice
Copy link
Member

@vdice vdice commented Mar 3, 2017

Ref #326

@vdice vdice added this to the v2.13 milestone Mar 3, 2017
@vdice vdice self-assigned this Mar 3, 2017
@vdice vdice requested a review from krancour March 3, 2017 18:53
@codecov-io
Copy link

codecov-io commented Mar 3, 2017 •
edited
Loading

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files           6        6           
  Lines         386      386           
=======================================
  Hits          215      215           
  Misses        151      151           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81d872...bbf8dee. Read the comment docs.

@vdice vdice force-pushed the add-aws-idle-timeout-annotation-to-router-service branch 2 times, most recently from ac46492 to 2481280 Compare March 3, 2017 19:41
@vdice vdice force-pushed the add-aws-idle-timeout-annotation-to-router-service branch from 2481280 to bbf8dee Compare March 3, 2017 21:03
@krancour krancour added the LGTM1 label Mar 4, 2017
@krancour
Copy link
Contributor

krancour commented Mar 4, 2017

For anyone who may have this concern, please note that this AWS-annotation will not have any adverse effect when this chart is installed elsewhere.

@krancour krancour mentioned this pull request Mar 6, 2017
Merged
vdice pushed a commit to vdice/workflow that referenced this pull request Mar 9, 2017
docs(configuring-load-balancers.md): mention forthcoming default
e384719 
Ref deis/router#327
@vdice vdice mentioned this pull request Mar 9, 2017
Merged
@bacongobbler
Copy link
Member

:shipit: ?

vdice pushed a commit to deis/workflow that referenced this pull request Mar 22, 2017
docs(configuring-load-balancers.md): mention forthcoming default (#768)
722795b 
Ref deis/router#327
@vdice vdice merged commit e16e7d8 into deis:master Mar 22, 2017
@vdice vdice deleted the add-aws-idle-timeout-annotation-to-router-service branch March 22, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees

@vdice vdice

Labels
LGTM1 LGTM2
Projects
None yet
Milestone
v2.13
Development

Successfully merging this pull request may close these issues.
5 participants
@vdice @codecov-io @krancour @bacongobbler @mboersma