-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(charts): quote annotation values #328
Conversation
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 6 6
Lines 386 386
=======================================
Hits 215 215
Misses 151 151
Partials 20 20 Continue to review full report at Codecov.
|
@@ -7,7 +7,7 @@ metadata: | |||
annotations: | |||
component.deis.io/version: {{ .Values.docker_tag }} | |||
{{- range $key, $value := .Values.deployment_annotations }} | |||
{{ $key }}: {{ $value }} | |||
{{ $key }}: "{{ $value }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a quote
function in sprig for this that might be safer to use here. It will escape any double quote that exists within the string to make it YAML safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point--I'll try | quote
.
27994bd
to
65b7487
Compare
I'll see if I can get service annotations working with this fix. |
This worked for me. LGTM!
|
I get errors trying to set
service_annotations
ordeployment_annotations
in testing #323. Templating the router service seems to be the initial problem, because therange
loop doesn't quote the values as required.Closes #325.