feat(git_push_test.go): add git push interrupt test #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vdice
force-pushed
the
git-push-interrupt
branch
2 times, most recently
from
41e5ca7
to
b8aab2b
Compare
| @@ -66,6 +66,8 @@ func StartCmd(command model.Cmd) (*gexec.Session, error) { | |||
| // supplied <timeout> until the <cmd> result contains the <expectedResult> | |||
| // An example use of this utility would be curl-ing a url and waiting | |||
| // until the response code matches the expected response. | |||
| // TODO: refactor to accept timeout of type time.Duration, potentially expected exit code was well | |||
| // TODO: or at least use RetryUntilResult below | |||
There was a problem hiding this comment.
@vdice can we get some GH issues for these, if they're not already in?
| pushCommandLineString, settings.GitSSH, keyPath)} | ||
|
|
||
| Eventually(cmd.RetryUntilResult(pushCmd, expectedCmdResult, 5*time.Second, | ||
| settings.DefaultEventuallyTimeout)).Should(BeTrue()) |
There was a problem hiding this comment.
can the default eventually timeout be specified in the env? wondering because we may need to change the builder's internal repo lock timeout sometime in the future
There was a problem hiding this comment.
@arschles yes, it appears it and MaxDefaultEventuallyTimeout can be overridden via env vars: https://github.com/deis/workflow-e2e/blob/master/tests/settings/settings.go#L20
vdice
force-pushed
the
git-push-interrupt
branch
from
b8aab2b
to
792dfd6
Compare
|
|
||
| // Satisfies returns whether or not the original CmdResult, ocd, meets all of | ||
| // the expectations contained in the expeced CmdResult, ecd | ||
| func (ocd CmdResult) Satisfies(ecd CmdResult) bool { |
There was a problem hiding this comment.
this receiver name describes my coding style perfectly
vdice
force-pushed
the
git-push-interrupt
branch
from
792dfd6
to
cc7ff9b
Compare
vdice
force-pushed
the
git-push-interrupt
branch
from
cc7ff9b
to
9490cc6
Compare
[skip ci] Depends on (currently pending) fix in deis/builder#369
vdice
force-pushed
the
git-push-interrupt
branch
from
9490cc6
to
a532726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some TODOs to address that I can move forward with if it sounds like this will still be wanted afterStill need to align with work done in #235Adds spec for deis/builder#369
cc @mboersma