-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor log #1008
refactor: refactor log #1008
Conversation
5871bab
to
4ee6718
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 58.16% 58.32% +0.16%
==========================================
Files 91 92 +1
Lines 5448 5529 +81
==========================================
+ Hits 3169 3225 +56
- Misses 1965 1989 +24
- Partials 314 315 +1
☔ View full report in Codecov by Sentry. |
b798924
to
55f86d1
Compare
55f86d1
to
1b5a2df
Compare
d2dd178
to
470f57d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some suggestion around documentation. thanks!
df0545f
to
438467b
Compare
438467b
to
3851fbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. thanks binbin!
9ed9546
to
0b0a476
Compare
c2d02ed
to
1704895
Compare
1704895
to
aa5776a
Compare
Signed-off-by: Yi Zha <yizha1@microsoft.com> chore: update constraint templates refactor: refactor log (ratify-project#1008) fix: display cert store status (ratify-project#1021) Co-authored-by: Binbin Li <libinbin@microsoft.com> chore: update constraint templates
Description
What this PR does / why we need it:
formatter
andrequestHeaders
to the helm chart value so that users can configure the logger.This is the first PR which just introduced the basic new logging framework to Ratify. There will be a following PR that refactors most logging lines to use the new logger util.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #972 #963
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Added unit tests.
A screenshot of local testing, all logs within a request have the same trace-id and have component-type set as well.
Checklist:
Post Merge Requirements
Helm Chart Change