Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with caching bindle assets #97

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

simongdavies
Copy link
Member

Fix for issue where mapping bindle to wagi config mounts the wrong path as a volume.

@simongdavies simongdavies merged commit 4711a3a into deislabs:main Jul 8, 2021
@simongdavies simongdavies deleted the fix-cache-bindle-assets branch July 8, 2021 19:08
@technosophos
Copy link
Contributor

technosophos commented Jul 14, 2021

I am reverting this one because this mounts one directory level to high. So for example, this should work:

$ curl -v localhost:3000/static/README.md

But it does not. And this should not work (basically, getting a file out of a parcel by SHA):

$ curl -v localhost:3000/static/158acdedb8163ad1e25822bbe51934663aca021f8d68bd91338e8f3d578dac7c/README.md

And the above does in fact work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants