Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMA returns empty results if java is not installed, making test assertions fail for the wrong reason #58

Closed
Archer6621 opened this issue Sep 27, 2023 · 5 comments

Comments

@Archer6621
Copy link
Contributor

Archer6621 commented Sep 27, 2023

Tested on MacOS 13.6 (Ventura).

This also affects other parts of the test suite that may use COMA, causing assertions to fail.

Probably the right course of action would be to throw an exception if COMA cannot be ran properly on the system, which can then be caught in the tests to make the user aware of this.

@Archer6621 Archer6621 changed the title COMA silently fails in tests if java is not installed and returns empty results COMA returns empty results if java is not installed, making test assertions fail for the wrong reason Sep 27, 2023
@Dome-s
Copy link

Dome-s commented Nov 8, 2023

i am currently getting a similar issue where COMA instance based returns no found matches for some of the datasets, probably due to an error i would assume but no error is being thrown.

@kPsarakis
Copy link
Member

@Dome-s COMA instance could also produce empty lists if it cannot find matches. If the Jar throws an exception, this propagates to Python. It does not generate an empty list.

Could you share any of the datasets?

@Dome-s
Copy link

Dome-s commented Nov 8, 2023

@kPsarakis I currently just tried it with the datasets from the corresponding paper for the following 2 for example no match was found. I figured since these are datasets that were used in the paper it is unlikely that not finding a match is correct, but maybe it is
miller2_both_0_50_ac5_ev_source.csv
miller2_both_0_50_ac5_ev_target.csv

this is a formated result file
comaInst_miller2_both_0_50_ac5_ev_.csv

@kPsarakis
Copy link
Member

@Dome-s, you are correct. These datasets do not produce output because Java runs out of memory. Try to increase the java_xmx parameter of the Coma matcher default: "1024m".

We will create better error messages for this. Thanks for reporting this!

@kPsarakis
Copy link
Member

This has been addressed in the latest release (v0.1.9) thanks a lot @Archer6621 and @Dome-s for pointing out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants