-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMA returns empty results if java is not installed, making test assertions fail for the wrong reason #58
Comments
i am currently getting a similar issue where COMA instance based returns no found matches for some of the datasets, probably due to an error i would assume but no error is being thrown. |
@Dome-s COMA instance could also produce empty lists if it cannot find matches. If the Jar throws an exception, this propagates to Python. It does not generate an empty list. Could you share any of the datasets? |
@kPsarakis I currently just tried it with the datasets from the corresponding paper for the following 2 for example no match was found. I figured since these are datasets that were used in the paper it is unlikely that not finding a match is correct, but maybe it is this is a formated result file |
@Dome-s, you are correct. These datasets do not produce output because Java runs out of memory. Try to increase the java_xmx parameter of the Coma matcher default: "1024m". We will create better error messages for this. Thanks for reporting this! |
This has been addressed in the latest release (v0.1.9) thanks a lot @Archer6621 and @Dome-s for pointing out this issue. |
Tested on MacOS 13.6 (Ventura).
This also affects other parts of the test suite that may use COMA, causing assertions to fail.
Probably the right course of action would be to throw an exception if COMA cannot be ran properly on the system, which can then be caught in the tests to make the user aware of this.
The text was updated successfully, but these errors were encountered: