Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change COMA API to have "use_instances" as keyword instead of "strategy" #60

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

Archer6621
Copy link
Contributor

@Archer6621 Archer6621 commented Sep 27, 2023

Resolves #57

Examples and readme.md have also been adjusted.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9d97d75) 85.28% compared to head (cadeb56) 85.28%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files          36       36           
  Lines        1645     1645           
=======================================
  Hits         1403     1403           
  Misses        242      242           
Files Coverage Δ
valentine/algorithms/coma/coma.py 87.14% <100.00%> (ø)
...lentine/algorithms/distribution_based/emd_utils.py 95.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@kPsarakis
Copy link
Member

The build for Python 3.12 now works on master. Try to rebase

@kPsarakis kPsarakis merged commit 3b67275 into delftdata:master Oct 10, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Coma API
3 participants