-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce output when installing/uninstalling #425
Conversation
Sample for commit 1 & 2. ll examples below taken with the xone DKMS modules as it contains a few modules which are a good representation of the output. Before:
After:
|
Sample for commit 3, again examples below are taken with the xone DKMS modules. Before, with a simple situation:
Before, with a more complicated case where modules are already there:
After, simple case (this is what most users will ever see):
After, more complex case with the same module already installed:
And with an original module being older:
|
Just did my update for Nvidia with this:
@evelikov any chance you can review it? |
Sorry for the delay, just catching up from being offline. Personally I like the leading slashes, but I'm not strongly attached. Reeeeally like the "done" piece though. Apart from the few comments, please update the test expectations. |
Adjusted for the review above, now checking the test expectations. |
a1a5f07
to
946b4a2
Compare
The tests apparently show some pre-existing race condition as I'm not able to get consistent output between Ubuntu and Alpine in a section I haven't touched. Will try to fix it soon. |
a47eff7
to
99860f7
Compare
@evelikov only on the Ubuntu VM Test, I get an extra newline, which does not seem to be there in the code, I guess it's some mangled output from the https://github.com/dell/dkms/actions/runs/9859049192/job/27221831634?pr=425 Everything else is green. Can't we consider all the container tests enough? |
Temporarily rebased on the |
I proposed a possible solution to this at #428 (review) |
b3ef72f
to
cf56e98
Compare
e4342c8
to
1739319
Compare
Also save multiple original modules on Debian/Ubuntu instead of just silently leaving everything in place.
The output when installing and uninstalling modules is unbelievably long, and in most cases it prints useless information.
Make some changes to print additional information only when relevant to the context and shorten output in general. List of commits, in order:
done.
" at the end of the dots when the task it's finished.