Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests update #428

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Tests update #428

merged 3 commits into from
Aug 18, 2024

Conversation

scaronni
Copy link
Collaborator

@scaronni scaronni commented Jul 7, 2024

  • CentOS 7 is EOL
  • Ubuntu 18.04 is EOL, and extra updates up to 2028 are only available with an Ubuntu Pro subscription and the "pro" tool.
  • Do not print dots on long operations when doing tests. I've found the parsing of the logs / removal of the dots very unreliable. This makes sure the extra progressing dots are not printed only during tests.
  • Drop Ubuntu VM test as it's inconsistent with the output (hit in Reduce output when installing/uninstalling #425 (comment)).

@scaronni scaronni requested a review from evelikov July 7, 2024 13:21
@scaronni scaronni force-pushed the tests branch 2 times, most recently from 86bc1ff to 666ba8d Compare July 7, 2024 15:01
@scaronni scaronni changed the title Drop EOL platforms from tests Tests update Jul 7, 2024
@scaronni scaronni requested a review from xuzhen July 14, 2024 08:04
@scaronni
Copy link
Collaborator Author

@evelikov or @xuzhen any chance for a review and merge?

Copy link
Collaborator

@evelikov evelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any references about the unreliable dot-dot-dot? Don't recall seeing any issues, although I haven't paid as much attention as I should have.

If it's not an isolated case, let's cross reference the yml in the dkms.in. So it's a bit harder to update one and not the other in the future.

Please copy/paste the nice summary from the PR into the respective commits.

- CentOS 7 is EOL
- Ubuntu 18.03 is EOL, and extra updates up to 2028 are only available with an Ubuntu Pro subscription and the "pro" tool
Parsing of the logs with removal of the dots from the ouput is very unreliable. This achieves the same result as printing/parsing/removing the extra progressing dots in the test results by just not printing them in the first place.
Somehow (probably shell related) the output is inconsistent between
containers and VM.
@scaronni
Copy link
Collaborator Author

scaronni commented Aug 6, 2024

Do you have any references about the unreliable dot-dot-dot? Don't recall seeing any issues, although I haven't paid as much attention as I should have.

It's linked in the other MR above, the VM output is not consistent with the container output. Note that I also tested with a CentOS Stream 9 VM and there the output is consistent with the AlmaLinux 9 container.

If it's not an isolated case, let's cross reference the yml in the dkms.in. So it's a bit harder to update one and not the other in the future.

Sorry not sure I understand, what do you mean?

Please copy/paste the nice summary from the PR into the respective commits.

Done.

@scaronni scaronni requested a review from evelikov August 6, 2024 08:03
@scaronni
Copy link
Collaborator Author

scaronni commented Aug 6, 2024

Btw, this is blocking the other pull requests as tests always fail. Thanks.

@scaronni scaronni requested a review from zeroepoch August 9, 2024 09:00
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
run_test.sh Show resolved Hide resolved
@scaronni
Copy link
Collaborator Author

Thanks!

@scaronni scaronni merged commit 094553c into master Aug 18, 2024
54 checks passed
@scaronni scaronni deleted the tests branch August 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants