-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests update #428
Tests update #428
Conversation
86bc1ff
to
666ba8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any references about the unreliable dot-dot-dot? Don't recall seeing any issues, although I haven't paid as much attention as I should have.
If it's not an isolated case, let's cross reference the yml in the dkms.in. So it's a bit harder to update one and not the other in the future.
Please copy/paste the nice summary from the PR into the respective commits.
- CentOS 7 is EOL - Ubuntu 18.03 is EOL, and extra updates up to 2028 are only available with an Ubuntu Pro subscription and the "pro" tool
Parsing of the logs with removal of the dots from the ouput is very unreliable. This achieves the same result as printing/parsing/removing the extra progressing dots in the test results by just not printing them in the first place.
Somehow (probably shell related) the output is inconsistent between containers and VM.
It's linked in the other MR above, the VM output is not consistent with the container output. Note that I also tested with a CentOS Stream 9 VM and there the output is consistent with the AlmaLinux 9 container.
Sorry not sure I understand, what do you mean?
Done. |
Btw, this is blocking the other pull requests as tests always fail. Thanks. |
Thanks! |
pro
" tool.