WIP: Feature/instance details #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l elements to increase the reusability for the instance details page
…nstance-details component
…ne given instance id. used in instance detail view to display the subnet of the given instance
… subnet (no connection possibilities then anyways)
…urce. fixed sorting.
… or component type
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
======================================
Coverage 0% 0%
======================================
Files 13 13
Lines 16 16
Branches 2 2
======================================
Misses 16 16Continue to review full report at Codecov.
|
ishwaryamamidi
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the new instance details page, reachable when left-clicking an instance in the graph-view. Also the notification center has been included in the table-overview component.
@ishwaryaPaderborn please have a look at the layout of the instance details page and the table-overview component and alter as you see fit.
@winniedo please have a look at the rework of your notification center and see if you are comfortable with these changes.