Skip to content

Conversation

janniclas
Copy link
Contributor

As described in #88 the docker controls are now hidden if the docker id of the instance is not set. If the instance has no docker id this means that it is not launched by docker and thus can't be controlled via the docker controls.

@ghost ghost assigned janniclas Jan 15, 2019
@ghost ghost added the review label Jan 15, 2019
@janniclas janniclas changed the base branch from master to develop January 15, 2019 20:18
Copy link
Contributor

@ishwaryamamidi ishwaryamamidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contol actions for instances are hidden if not hosted by docker. Otherwise a valid message is shown, Works fine.

@janniclas janniclas merged commit 1a29a31 into develop Jan 17, 2019
@janniclas janniclas deleted the feature/dockerControlsUpdate branch January 17, 2019 07:05
@ghost ghost removed the review label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants