-
Notifications
You must be signed in to change notification settings - Fork 2
Added data model representation for links between instances #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint. Extended /matchingInstance and /matchingResult with parameter 'Id' to pass the id of the calling instance. Changed specification, server and request handler accordingly. No db changes yet.
…o. Connected them to the RequestHandler. Still need to evaluate links in matching algorithm.
Still need to implement fallback algorithm and update the tests.
… matching does not yield result. Stop is now able to call /stop on instances that are not running inside a docker container.
LinkAddedEvent and LinkStateChangedEvent added. Fixed tests not compiling due to api change.
…?Id=42). Whole network is now accessible (new type InstanceNetwork) via /network.
… Added hint in Requirements section of readme.
… now provides an endpoint to add labels to an instance. Label length is limited to a maximum number of 50 characters (may be adapted in configuration file).
…ing. Adapted RequestHandlerTest to new feautures. Fixed a bug in requesthandler.
Logs will be provided in a separate branch.
24santoshr
approved these changes
Nov 8, 2018
This was referenced Nov 8, 2018
This was referenced Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
The re-design of the Delphi management UI uncovered the need for additional data and functionality provided by the registry. This included:
Solution
Add "InstanceLinks" to the data model, require the additional data to create links in the API endpoints, add labels to the data model of the "Instance". Provide endpoints to retrieve links. Provide endpoints to assign labels.
Changes
1. Look for links from the calling instance to instances of the requested type with state 'Assigned'. If any are found match, else goto phase 2
2. Look for instances of the requested type that share labels with the calling instance, select the one with the most labels in common. If none exist, goto phase 3
3. Look for instances of the requested type that have the most positive matching results in a row. Match to this instance (may have 0 positive results). If no instance of the specified type is present, fail matching process.