Skip to content

Conversation

johannesduesing
Copy link

Reason for this PR
The instance registry will require authentication based on JSON Web Tokens (JWTs) soon (as described here). The components of the Delphi system have to be able to generate valid JWTs based on a secret that is either passed in an environment variable or in the configuration file. They have to add the encoded token in the Authorization header of every HTTP request issued to the registry. For more information see the respective issue.

Changes in this PR

  • The WebApi is now able to generate valid JWTs based on a secret specified in an environment variable (using HS256 signature algorithm)
  • The WebApi sends an encoded valid JWT with every request issued to the registry
  • A bug has been fixed that prevented the application from shutting down when trying to report shutdown to the registry

@johannesduesing johannesduesing self-assigned this Jan 3, 2019
@ghost ghost added the review label Jan 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #41 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #41      +/-   ##
==========================================
- Coverage      1.4%   1.39%   -0.01%     
==========================================
  Files           18      19       +1     
  Lines          427     429       +2     
  Branches        31      33       +2     
==========================================
  Hits             6       6              
- Misses         421     423       +2
Impacted Files Coverage Δ
...ain/scala/de/upb/cs/swt/delphi/webapi/Server.scala 0% <0%> (ø) ⬆️
...la/de/upb/cs/swt/delphi/webapi/Configuration.scala 0% <0%> (ø) ⬆️
...swt/delphi/webapi/authorization/AuthProvider.scala 0% <0%> (ø)
...t/delphi/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbb9df...90cc6e3. Read the comment docs.

@bhermann bhermann merged commit 8ce9788 into develop Jan 4, 2019
@bhermann bhermann deleted the feature/authentication branch January 4, 2019 12:49
@ghost ghost removed the review label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants