Webapp connection to instance registry #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/utils/instancemanagement/InstanceRegistry.scala
Removed some unnecessary if-conditions
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
======================================
Coverage 0% 0%
======================================
Files 2 8 +6
Lines 22 172 +150
Branches 2 15 +13
======================================
- Misses 22 172 +150
Continue to review full report at Codecov.
|
bhermann
approved these changes
Sep 19, 2018
bhermann
requested changes
Sep 19, 2018
build.sbt
Outdated
| @@ -21,6 +21,14 @@ resolvers += Resolver.sonatypeRepo("snapshots") | |||
|
|
|||
| libraryDependencies += guice | |||
| libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "3.1.2" % Test | |||
| libraryDependencies += "org.parboiled" %% "parboiled" % "2.1.4" | |||
There was a problem hiding this comment.
Why does the webapp project need parboiled2?
build.sbt
Outdated
| libraryDependencies += "com.typesafe.akka" %% "akka-stream" % "2.5.12" | ||
| libraryDependencies += "com.typesafe.akka" %% "akka-http-spray-json" % "10.1.1" | ||
| libraryDependencies += "io.spray" %% "spray-json" % "1.3.3" | ||
| libraryDependencies += "org.parboiled" %% "parboiled" % "2.1.4" |
There was a problem hiding this comment.
Dependency is added twice. Is this necessary?
build.sbt
Outdated
| @@ -21,6 +21,14 @@ resolvers += Resolver.sonatypeRepo("snapshots") | |||
|
|
|||
| libraryDependencies += guice | |||
| libraryDependencies += "org.scalatestplus.play" %% "scalatestplus-play" % "3.1.2" % Test | |||
| libraryDependencies += "org.parboiled" %% "parboiled" % "2.1.4" | |||
| libraryDependencies += "com.typesafe.akka" %% "akka-http" % "10.0.11" | |||
There was a problem hiding this comment.
Please use the more current version 10.1.5. (see delphi-cli for migration)
Also, you might be able to just use the smaller akka-http-core library.
build.sbt
Outdated
| libraryDependencies += "com.typesafe.akka" %% "akka-http-spray-json" % "10.1.1" | ||
| libraryDependencies += "io.spray" %% "spray-json" % "1.3.3" | ||
| libraryDependencies += "org.parboiled" %% "parboiled" % "2.1.4" | ||
| libraryDependencies += "org.scalactic" %% "scalactic" % "3.0.4" |
bhermann
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webapp creates a entry on instance registry also it request for a Webapi instance from instance registry to perform required task