Skip to content

New api implementation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 11, 2018
Merged

New api implementation #22

merged 23 commits into from
Nov 11, 2018

Conversation

sami-cseseu
Copy link
Contributor

Added functionality for new API implementation

@ghost ghost assigned sami-cseseu Oct 13, 2018
@ghost ghost added the review label Oct 13, 2018
@codecov
Copy link

codecov bot commented Oct 13, 2018 •
edited
Loading

Codecov Report

Merging #22 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #22   +/-   ##
=====================================
  Coverage        0%    0%           
=====================================
  Files            8    10    +2     
  Lines          172   234   +62     
  Branches        15    23    +8     
=====================================
- Misses         172   234   +62
Impacted Files Coverage Δ
app/EagerLoaderModule.scala 0% <ø> (ø) ⬆️
app/utils/CommonHelper.scala 0% <0%> (ø)
app/controllers/SettingsController.scala 0% <0%> (ø)
app/services/StartUpService.scala 0% <0%> (ø) ⬆️
app/utils/AppLogging.scala 0% <0%> (ø) ⬆️
app/controllers/HomeController.scala 0% <0%> (ø) ⬆️
...pp/utils/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️
app/utils/Configuration.scala 0% <0%> (ø) ⬆️
app/utils/instancemanagement/Instance.scala 0% <0%> (ø) ⬆️
app/utils/BlockingHttpClient.scala 0% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b1f339...40e70ac. Read the comment docs.

@bhermann
Copy link
Member

If this PR is ready for review, please assign a reviewer.

@bhermann bhermann mentioned this pull request Oct 15, 2018
Closed
@sami-cseseu sami-cseseu requested a review from bhermann October 15, 2018 16:26
@johannesduesing johannesduesing mentioned this pull request Oct 21, 2018
Closed
@ghost ghost assigned johannesduesing Oct 25, 2018
@johannesduesing
Copy link
Contributor

@bhermann i closed the PR #21 (which is contained in this PR) and cleaned up all the build- and codestyle-related issues in this PR. Please let me know if there is anything that should be changed so that this code can be merged to develop.

bhermann
bhermann requested changes Nov 6, 2018
View reviewed changes
Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the code according to the comments.

Johannes Duesing added 3 commits November 8, 2018 14:55
Implemented new matching interface
8598cf6 
Fixed a bug where invalid configuration attribute was used when executing a query.
Removed the stop endpoint.
91a49db 
Will be re-introduced once an authentication framework has been developed.
Fixed protocol check using 'contains' instead of 'startsWith'.
40e70ac
@bhermann bhermann merged commit bdac1a5 into develop Nov 11, 2018
@ghost ghost removed the review label Nov 11, 2018
@bhermann bhermann deleted the newApiImplementation branch November 11, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannesduesing johannesduesing johannesduesing left review comments

@bhermann bhermann bhermann approved these changes

Assignees

@sami-cseseu sami-cseseu

@johannesduesing johannesduesing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sami-cseseu @bhermann @johannesduesing