DLPX-95335 delphix-sb-enroll.service fails on OCI VMs #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On OCI VMs, the service fails to start
It turned out the OCI VMs don’t have the SecureBoot efivar, likely because secure boot is explicitly disabled.
A simple fix would be to move the check for AWS platform to earlier since secure boot is only supported on AWS at the moment. This way we wouldn’t even look for SecureBoot efivar for non-AWS systems.Solution
Confirmed delphix-sb-enroll.service no longer fails on all platforms.Testing Done
Successful appliance builds:
OCI - https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/12072/console
ESX, AWS, Azure, GCP - https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/12080/console