DLPX-91307 Install packages from dms-core-gate build-dependencies #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjang-dlpx
force-pushed
the
dlpx/pr/pjang-dlpx/4d2706f8-489c-41e6-b2eb-5425092ffb87
branch
2 times, most recently
from
437fe67 to
3676057
Compare
pjang-dlpx
commented
Jun 6, 2024
pjang-dlpx
force-pushed
the
dlpx/pr/pjang-dlpx/4d2706f8-489c-41e6-b2eb-5425092ffb87
branch
from
3676057 to
af5fbe0
Compare
pjang-dlpx
changed the title
pjang-dlpx
force-pushed
the
dlpx/pr/pjang-dlpx/4d2706f8-489c-41e6-b2eb-5425092ffb87
branch
from
af5fbe0 to
659880b
Compare
sebroy
approved these changes
Jun 6, 2024
prakashsurya
approved these changes
Jun 10, 2024
pjang-dlpx
deleted the
dlpx/pr/pjang-dlpx/4d2706f8-489c-41e6-b2eb-5425092ffb87
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The masking engine is upgrading to Java 17, which is not currently installed in the appliance. See the CP here for more context.
Solution
We are adding a build-dependencies file to dms-core-gate, similar to dlpx-app-gate through https://github.com/delphix/dms-core-gate/pull/1289, where we are also specifying openjdk-17. This change references this file and installs packages listed.
Testing Done
Verified that build-package for the delphix-masking package pulls openjdk-17-jdk from build-dependencies file in dms-core-gate's repo and successfully installs it as a build dependency: http://selfservice.jenkins.delphix.com/job/linux-pkg/job/develop/job/build-package/job/masking/job/pre-push/113/
Throughout the learning process of this change, I also noticed that the README was slightly out of date. This change also includes some README changes, with the help of @prakashsurya.Notes to Reviewers