Skip to content

Fix Current Pylint Errors #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix Current Pylint Errors #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sdb/commands/zfs/histograms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ def print_histogram(hist: drgn.Object,
max_count = count

HISTOGRAM_WIDTH_MAX = 40
if max_count < HISTOGRAM_WIDTH_MAX:
max_count = HISTOGRAM_WIDTH_MAX
max_count = max(max_count, HISTOGRAM_WIDTH_MAX)

if min_bucket > max_bucket:
print(f'{" " * indent}** No histogram data available **')
Expand Down
6 changes: 6 additions & 0 deletions sdb/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ def invoke(myprog: drgn.Program, first_input: Iterable[drgn.Object],
# at the end.
#
if shell_cmd is not None:
#
# This is a false-positive from pylint as we need
# to explicitly wait for shell_proc to be done and
# re-arrange our std_out.
#
# pylint: disable=consider-using-with
shell_proc = subprocess.Popen(shell_cmd,
shell=True,
stdin=subprocess.PIPE,
Expand Down