Skip to content

Conversation

mothslaw
Copy link
Contributor

@mothslaw mothslaw commented Oct 7, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No mention of default

What is the new behavior?

Added a warning about misinterpreting JSON schema's default keyword. (Also fixed a couple of incorrect quote characters)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@nhlien93 nhlien93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, just adding the one line about what it actually is used for would be my only comment as well.

@mothslaw mothslaw merged commit 159431b into delphix:develop Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants