Skip to content

Update engine api for snapshot parameters and rewrite params default to none when json is empty #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2020
Merged

Update engine api for snapshot parameters and rewrite params default to none when json is empty #260

merged 2 commits into from
Oct 15, 2020

Conversation

nhlien93
Copy link
Contributor

@nhlien93 nhlien93 commented Oct 12, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current vs new behavior?

There are a couple things in this change:

  1. The engine api is changed to 1.12.0. This is necessary to get our trunk delphix engine to work, after the delphix engine changes get backported to an older api we will have to make another change
  2. The snapshot parameters definition schema is an actual object rather than just a json v4. therefore the build has to be updated.
  3. Swagger generated objects are empty if the json blob is None. I change the behavior to make the object None as well.

Does this introduce a breaking change?

  • Yes
  • No

@nhlien93 nhlien93 changed the title Snapshotparams Update engine api for snapshot parameters and rewrite params default to none when json is empty Oct 13, 2020
@nhlien93 nhlien93 added this to the VSDK Sprint 9/24-10/15 milestone Oct 14, 2020
@nhlien93 nhlien93 marked this pull request as ready for review October 14, 2020 20:48
@nhlien93 nhlien93 requested a review from ankursarin as a code owner October 14, 2020 20:48
ankursarin
ankursarin approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

jeffngo
jeffngo approved these changes Oct 14, 2020
View reviewed changes
ravi-cm
ravi-cm approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nhlien93 nhlien93 merged commit e6f1896 into delphix:develop Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-cm ravi-cm ravi-cm approved these changes

+2 more reviewers

@ankursarin ankursarin ankursarin approved these changes

@jeffngo jeffngo jeffngo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
VSDK Sprint 9/24-10/15
Development

Successfully merging this pull request may close these issues.
4 participants
@nhlien93 @ankursarin @jeffngo @ravi-cm