Skip to content

Conversation

ravi-cm
Copy link
Contributor

@ravi-cm ravi-cm commented Nov 1, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x]Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):
    SDK changes to reflect the backend changes to rename name->id and prettyName->name.
  1. Removed the plugin_config_schema which skipped id validation. Also removed the skip-id-validation flag in CLI.
  2. Changed artifact creation to include pluginId and name fields per the new schema.
  3. Adjusted unit tests where required.
  4. Changed dvp download-logs to use plugin/toolkit identifier to match the required plugin when downloading logs.

What is the current behavior?

artifact has "name" and "prettyName" fields which are renamed now on the backend side.
Issue Number: 53

What is the new behavior?

  • artifact will now have pluginId and name fields to match the engine schema.

Does this introduce a breaking change?

  • Yes
  • No

Old plugins need to be built with new SDK to upload to a newer engine.

Other information

  1. Tested with a plugin build with this new changes and uploaded to DE.
  2. Tested download logs with the new changes.
  3. Tested plugin upgrade by uploading to an engine that already has an old plugin (built without these changes).
  4. Tested by trying upload to an older engine and made sure failure is reported.

@ravi-cm ravi-cm added this to the VSDK Sprint 10/15-11/05 milestone Nov 1, 2020
@ravi-cm ravi-cm self-assigned this Nov 1, 2020
@ravi-cm ravi-cm linked an issue Nov 1, 2020 that may be closed by this pull request
@ravi-cm ravi-cm closed this Dec 1, 2020
@ravi-cm ravi-cm reopened this Dec 1, 2020
@ravi-cm ravi-cm closed this Dec 1, 2020
@ravi-cm ravi-cm deleted the branch delphix:develop December 1, 2020 02:38
@ravi-cm ravi-cm deleted the develop branch December 1, 2020 02:38
@ravi-cm ravi-cm restored the develop branch December 1, 2020 02:40
@ravi-cm ravi-cm reopened this Dec 1, 2020
@ravi-cm
Copy link
Contributor Author

ravi-cm commented Dec 4, 2020

Tested w/ engine changes and new SDK changes.

@ravi-cm ravi-cm merged commit 9ed06b4 into delphix:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rename "name" to "plugin_id" and "prettyName" to "name"
4 participants