Skip to content

Conversation

jeffngo
Copy link
Contributor

@jeffngo jeffngo commented Jan 6, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Added feature to mkdocs.yml to get past an error I was seeing trying to run pipenv run mkdocs serve.
  File "/Users/jngo/Documents/workspace/vsdk/docs/material/404.html", line 1, in top-level template code
    {% extends "base.html" %}
  File "/Users/jngo/Documents/workspace/vsdk/docs/material/base.html", line 118, in top-level template code
    {% if feature.tabs %}
  File "/Users/jngo/virtualenv/mkdocs/lib/python3.9/site-packages/jinja2/environment.py", line 471, in getattr
    return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: 'mkdocs.theme.Theme object' has no attribute 'feature'
  • Included the fix that I merged with trunk (707d0de)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jeffngo jeffngo added this to the VSDK Sprint 12/17 - 01/07 milestone Jan 6, 2021
@jeffngo jeffngo self-assigned this Jan 6, 2021
@jeffngo jeffngo force-pushed the spd-docs branch 2 times, most recently from 251421a to a778f67 Compare January 6, 2021 23:56
@jeffngo jeffngo changed the base branch from develop to release/3.0.0 January 7, 2021 19:37
Copy link
Contributor

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeffngo jeffngo merged commit 6acfa72 into delphix:release/3.0.0 Jan 13, 2021
jeffngo added a commit to jeffngo/virtualization-sdk that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants