Fixes PYT-900 : Initial migration: Write pre commit action #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Github actions were successful on my fork : https://github.com/muralinimmagadda/virtualization-sdk/pull/3/checks |
muralinimmagadda
requested review from
ankursarin,
fdrozdowski and
grantmagdanz
as code owners
fdrozdowski
previously approved these changes
Jan 28, 2020
muralinimmagadda
dismissed stale reviews from grantmagdanz and fdrozdowski
via
74986df
grantmagdanz
approved these changes
Jan 29, 2020
fdrozdowski
approved these changes
Jan 29, 2020
13 tasks
mothslaw
added a commit
that referenced
this pull request
Aug 12, 2020
Merge pull request #239 from mothslaw/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: PYT-900
What is the new behavior?
Added Github Action for pre-commit that runs unit tests on common, libs, platform, tools projects of virtualization-sdk. It also lints tools project as of now. linting for other projects can be added later.
Job for checking format of projects is added but commented out so that it can be enabled once the formatting is fixed.
setup.py files are modified to use the dvp-api dependency from test pypi as artifactory cannot be used by github actions
Fixed an existing testcase that was failing in ubuntu environment
Does this introduce a breaking change?
Other information