Flashpoint Release 201

[crestdatasystems]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Description

• Fixed an issue with the resource URL incident field in cases where it is not populated by default.

Must have

• Tests
• Documentation

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @tcarmeli1 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @crestdatasystems, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[tcarmeli1]

Hi @crestdatasystems ,
Thank you for your contribution!
Good work :)
Please see my comments.
General comment- Please add new unit tests for the new functionality you added.
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

[crestdatasystems]

Hi @crestdatasystems , Thank you for your contribution! Good work :) Please see my comments. General comment- Please add new unit tests for the new functionality you added. Please feel free to reach out to me with any questions - I'm available here or on slack :) Thanks again

Hi @tcarmeli1,
Thanks for reviewing the PR.
The intention of this release was to resolve the issue of unavailability of the Resource URL.

• In some of type of alerts, the Resource URL is directly available from the API response.
• To resolve the issue, we have forged custom Resource URL based on the type of Alert.
• So, there is no change in any major functionality. And we also wanted to check that the existing test cases should pass, and there should be only change in test data to check that existing functionality haven't affected due to this release.
• This was the reason to not modify the test cases.

[tcarmeli1]

Hi @crestdatasystems ,
Thank you for your response!
It depends on your decision but i would suggests adding one more test in order to test the functionality when a Resource URL is not provided by the API.
In addition, I would appreciate if you can please create a Demo video so i can go on and merge this pr, we can also conduct a Demo meeting if you prefer.
Thank you so much!

[tcarmeli1]

Watched the demo- all looks great.
Great work!

[github-actions]

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.