Flashpoint ignite - is_time_sensitive() related changes

[ShacharKidor]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

relates: CIAC-12908

Description

• Improved implementation of all the integration commands where the number of retries was lowered to 0 and the request timeout was lowered to 15 seconds when a command is called during an enrichment process.

Must have

• Tests
• Documentation

[github-actions]

Your contributed Flashpoint pack has been modified on files:

Packs/Flashpoint/pack_metadata.json
Packs/Flashpoint/ReleaseNotes/2_0_5.md
Packs/Flashpoint/Integrations/Ignite/Ignite.py
Please review the changes here

• @kashyap-solanki

[CLAassistant]

All committers have signed the CLA.

[content-bot]

The following errors were thrown as a part of this pr: ST111.
The following errors cannot be ignored: ST111.
The following errors don't run as part of the nightly flow and therefore can be force merged: ST111.
##############################################################
Please note that the PR can be force merged from the validation perspective.
##############################################################

[content-bot]

This PR is marked as 'Stale' because it has been open for 30 days with no activity, it will be automatically closed in 15 days if no activity will be done. To reset the counter just remove the 'Stale' label or make changes to update this PR. If you wish this PR will never be marked as 'Stale' add the 'Ignore Stale'

[content-bot]

This PR is marked as 'Stale' because it has been open for 30 days with no activity, it will be automatically closed in 15 days if no activity will be done. To reset the counter just remove the 'Stale' label or make changes to update this PR. If you wish this PR will never be marked as 'Stale' add the 'Ignore Stale'

[LHousehold]

Hello, this is Luke from Flashpoint. We've tested this change and it functions correctly and as expected. Thank you for your patience as we've been working through this.

On the technical side we have been discussing and we do have a concern that even a small network hiccup would cause the enrichment command to fail and harm the experience for customers. We'd like to suggest changing the 10 seconds to 15, and changing the 0 retries to 2 (the first retry happens instantly). Considering the feedback from yourselves and the customer, we agree that the current retry method is too heavy for enrichment purposes, but having no retries feels like a risk as well. If your team is okay with 15s and 2 retries, we can agree to this change immediately.

Additionally when we make these changes, we can also observe by how much this particular customers' timing is improved and discuss if we need to further reduce the timing or restrategize.

What are your thoughts?

[ShacharKidor]

Hi @LHousehold ,

Thanks for the update and for validating the fix.

I’ll increase the timeout to 15 seconds as suggested. However, regarding the retry count, we believe it's best to keep it at 0. During enrichment, minimizing the number of calls is critical to ensure optimal performance—additional retries could significantly degrade the user experience.

Let me know your thoughts.

Best regards,
Shachar

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/Flashpoint/Integrations/Ignite
Ignite.py	1030	43	95%	227, 292, 310–316, 392, 556, 559, 651, 846, 1084–1085, 1126, 1285, 1367, 1669, 1907–1912, 1914, 2084, 2090–2091, 2099, 2137–2138, 2443–2446, 2456, 2468, 2473–2474, 2477, 2481
TOTAL	1030	43	95%

Tests	Skipped	Failures	Errors	Time
91	0 💤	0 ❌	0 🔥	4.217s ⏱️

[content-bot]

Validate summary
The following errors were thrown as a part of this pr: RN106, ST111, PA114, DO106.
The following errors cannot be ignored: RN106, ST111, PA114, DO106.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN106, ST111, PA114, DO106.

Verdict: PR can be force merged from validate perspective? ✅

[ShacharKidor]

@yuvalbenshalom - Please force merge the PR.
The [ST111] validation is failing for missing section headers, I didn't add the since this is a partner pack.