added new XSIAM content items - case fields, layouts and layout rules #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
DeanArbel
reviewed
Jun 2, 2024
Comment on lines
193
to
195
| self.data["group"] != "incident" | ||
| and self.data["group"] != "indicator" | ||
| and self.data["group"] != "case" |
There was a problem hiding this comment.
This pairing tends to repeat itself (incident + indicator + case) - usually when there's such a strong pairing it's better to unify them under a common constant, and use the constant for conditions.
Let's discuss this offline
yucohen
changed the title
yucohen
commented
Jun 2, 2024
|
Changelog(s) in markdown:
|
…nto CIAC-9930-xsiam_content_items
|
Changelog(s) in markdown:
|
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9930
Description
Added support for new Case content items: Fields, Layouts and Layout rules.
bucket link: https://console.cloud.google.com/storage/browser/marketplace-ci-build/content/builds/CIAC-9930-xsiam_content_items/1062944/marketplacev2;tab=objects?prefix=&forceOnObjectsSortingFiltering=false