Skip to content

Conversation

eNeRGy164
Copy link
Member

This pull request introduces new classes and extension methods for handling UML diagrams and visibility modifiers, along with updates to package versions.

Updated package versions for DendroDocs.Shared and added PlantUml.Builder in relevant configuration files.

@Copilot Copilot AI review requested due to automatic review settings July 3, 2025 16:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds UML sequence diagram support by introducing new fragment classes, navigation extensions, and PlantUML visibility mapping, alongside updating package versions.

  • Introduced base and concrete UML fragment classes (InteractionFragment, Interactions, Arrow, Alt, AltSection)
  • Added extension methods for fragment traversal (Descendants, Ancestors, StatementsBeforeSelf) and for mapping IHaveModifiers to PlantUML visibility
  • Updated package versions for DendroDocs.Shared and added PlantUml.Builder to dependencies

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/DendroDocs.Client.Tests/packages.lock.json Bumped DendroDocs.Shared version and added PlantUml.Builder
src/DendroDocs.Client/packages.lock.json Bumped DendroDocs.Shared version and added PlantUml.Builder
Directory.Packages.props Updated DendroDocs.Shared version and added PlantUml.Builder
src/DendroDocs.Client/DendroDocs.Client.csproj Added PlantUml.Builder package reference
src/DendroDocs.Client/Uml/Fragments/InteractionFragment.cs New abstract base class for UML fragments
src/DendroDocs.Client/Uml/Fragments/Interactions.cs New Interactions fragment subclass
src/DendroDocs.Client/Uml/Fragments/Arrow.cs New Arrow fragment class
src/DendroDocs.Client/Uml/Fragments/Alt.cs New Alt fragment class
src/DendroDocs.Client/Uml/Fragments/AltSection.cs New AltSection fragment class
src/DendroDocs.Client/Uml/Fragments/Extensions/InteractionFragmentExtensions.cs Added traversal helper methods (Descendants, Ancestors, StatementsBeforeSelf)
src/DendroDocs.Client/Uml/Extensions/IHaveModifiersExtensions.cs Added ToPlantUmlVisibility extension for IHaveModifiers
Comments suppressed due to low confidence (3)

src/DendroDocs.Client/Uml/Fragments/Extensions/InteractionFragmentExtensions.cs:32

  • The Descendants method only recurses into Alt sections and does not traverse children of other fragments (e.g., Interactions). To fully implement "query all descendants" behavior, add a default recursion branch after the switch that descends into node.Fragments.
                case Alt a:

src/DendroDocs.Client/Uml/Fragments/Alt.cs:18

  • The summary for AddSection reads "Add a sections to this alt."—correct the grammar to "Add a section to this alt."
    /// <summary>

src/DendroDocs.Client/Uml/Fragments/Extensions/InteractionFragmentExtensions.cs:1

  • The file uses LINQ methods (SelectMany, TakeWhile) but does not include using System.Linq;. Add the missing using System.Linq; directive to ensure the code compiles.
namespace DendroDocs.Uml.Fragments.Extensions;

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16055800817

Details

  • 77 of 77 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 15992324803: 0.0%
Covered Lines: 298
Relevant Lines: 298

💛 - Coveralls

@eNeRGy164 eNeRGy164 added the enhancement New feature or request label Jul 3, 2025
@eNeRGy164 eNeRGy164 merged commit de2eb7a into main Jul 3, 2025
5 checks passed
@eNeRGy164 eNeRGy164 deleted the uml branch July 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants