Fix protobuf support on 32-bit architectures #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The int type size depends on the architecture, and when the type is 32-bit then 64-bit values will not fit.
|
BTW noticed this as part of the Debian CI system. https://tracker.debian.org/pkg/golang-github-dennwc-varint |
dennwc
approved these changes
Nov 19, 2021
|
Yes, latest prometheus versions are using it now. :) https://github.com/prometheus/prometheus/blob/main/go.mod#L15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The int type size depends on the architecture, and when the type is 32-bit then 64-bit values will not fit.