Skip to content

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 6, 2023

Remotes:

Actions:

  1. Closed previous "Upgrade to TS 5.2.2" PR
  2. git checkout upstream/release-5.3 and ensured it was on the commit of the release.
  3. git checkout -b branch_v5.3.3
  4. git push denoland
  5. git checkout -b branch_v5.3.3_patch
  6. Cherry picked changes in branch_v5.2.2_patch (excluding the import attributes change)
  7. npm install && npx hereby (to build)
  8. Inspected all usages of "globals" and "globalThisSymbol" in checker.ts (being aware that globalThisType might refer to the global this type and not the global globalThis type)
  9. Ran gulp local
  10. cp built/local/typescript.js ../deno/cli/tsc/00_typescript.js
  11. Copied the .d.ts files from built/local to ../deno/cli/tsc/dts as appropriate (all the ones currently in deno/cli/tsc/dts).
  12. Reviewed the dts files and made any modifications (reverts) necessary
  13. Search for "5.2.2" in the Deno codebase and replace with the new version
  14. Ran cargo test lsp and cargo test check
  15. Opened this PR with base branch_v5.3.3

https://github.com/denoland/deno/tree/main/cli/tsc#how-to-upgrade-typescript

Todo: Check if temporal changes are still relevant.

dsherret added a commit to denoland/deno that referenced this pull request Dec 6, 2023
@dsherret dsherret closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant