Skip to content

Node conditions order ignored #60

@marvinhagemeister

Description

@marvinhagemeister

The order of the passed node conditions is ignored. It won't check them left to right, but rather pick any matching piece. This causes problems when a package unexpectedly uses the CJS entrypoint instead of ESM.

  1. Run deno init
  2. Run deno i jsr:@deno/loader npm:@radix-ui/themes
  3. Run this script:
import { ResolutionMode, Workspace } from "@deno/loader";

const loader = await new Workspace({
  platform: "browser",
  preserveJsx: true,
  cachedOnly: true,
  nodeConditions: ["import", "require"],
}).createLoader();

const resolved = await loader.resolve(
  "@radix-ui/themes",
  "foo.tsx",
  ResolutionMode.Import
);

// Picks require entry instead of import
console.log({ resolved });

Metadata

Metadata

Assignees

No one assigned

    Labels

    important for freshIssues that are important for Fresh users

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions