Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build broken due to ts upgrade #1259

Closed
ry opened this issue Dec 1, 2018 · 8 comments
Closed

build broken due to ts upgrade #1259

ry opened this issue Dec 1, 2018 · 8 comments

Comments

@ry
Copy link
Member

ry commented Dec 1, 2018 •
edited
Loading

Experienced on 5d161f3
Something related to the recent TS upgrade.

> ./tools/build.py && ./tools/test.py
ninja: Entering directory `/Users/rld/src/deno/target/debug'
[256/419] ACTION //:deno_runtime_declaration(//build/toolchain/mac:clang_x64)
FAILED: gen/lib/lib.deno_runtime.d.ts
python ../../tools/run_node.py ../../node_modules/ts-node/dist/bin.js --project /Users/rld/src/deno/tools/ts_library_builder/tsconfig.json ../../tools/ts_library_builder/main.ts --basePath ../.. --buildPath . --outFile gen/lib/lib.deno_runtime.d.ts --silent --debug
../../../../../../node_modules/typescript/lib/lib.esnext.d.ts:24:21 - error TS2727: Cannot find lib definition for 'esnext.bigint'. Did you mean 'esnext.intl'?

24 /// <reference lib="esnext.bigint" />
                       ~~~~~~~~~~~~~

[259/419] ACTION //build_extra/rust:ring_rustc(//build/toolchain/mac:clang_x64)
ninja: build stopped: subcommand failed.
@ry ry changed the title mac debug build broken build broken due to ts upgrade Dec 1, 2018
@ry
Copy link
Member Author

ry commented Dec 1, 2018

false alarm. it was something local to my machine.

@ry ry closed this as completed Dec 1, 2018
@kevinkassimo
Copy link
Contributor

This error also just happens to my local machine after some sync_third_party attempt. How is this resolved?

@ry
Copy link
Member Author

ry commented Jan 24, 2019

@kevinkassimo I think it disappeared after a clean build?

@ry ry reopened this Jan 24, 2019
@ry
Copy link
Member Author

ry commented Jan 24, 2019 •
edited
Loading

I'm now experiencing this again on OSX (not Linux) at d0dc4de.

@kitsonk
Copy link
Contributor

kitsonk commented Jan 25, 2019

that error would directly relate to Node.js resolving a version of TypeScript that is prior to 3.2. I don't know if any of the deps being changed messed with the version of TypeScript that are being used/resolved, but it would have something related to that...

@ry
Copy link
Member Author

ry commented Jan 25, 2019

I found that if I revert d0dc4de it works.

ry added a commit to ry/deno that referenced this issue Jan 25, 2019
@ry
Revert "Upgrade tslint and friends (denoland#1571)"
956a714 
This commit was cauing a still problem described here:
denoland#1259

This reverts commit d0dc4de.
@ry ry mentioned this issue Jan 25, 2019
Merged
@kitsonk
Copy link
Contributor

kitsonk commented Jan 25, 2019

I tried it with d0dc4de on my Mac, with the appropriate submodule checkout and didn't have the problem... 🤷‍♂️

ry added a commit that referenced this issue Jan 26, 2019
@ry
Revert "Upgrade tslint and friends (#1571)" (#1573)
75f3499 
This commit was cauing a still problem described here:
#1259

This reverts commit d0dc4de.
@bartlomieju
Copy link
Member

CC @ry this issue is stale, can it be closed?

@ry ry closed this as completed May 20, 2019
Tzikas added a commit to Tzikas/squares that referenced this issue Sep 10, 2019
@Tzikas
Revert "Upgrade tslint and friends (#1571)" (#1573)
cc20420 
This commit was cauing a still problem described here:
denoland/deno#1259

This reverts commit d0dc4de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ry @kitsonk @bartlomieju @kevinkassimo