Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napi: returning value from initializer is ignored #17349

Closed
bartlomieju opened this issue Jan 11, 2023 · 3 comments · Fixed by #17502
Closed

napi: returning value from initializer is ignored #17349

bartlomieju opened this issue Jan 11, 2023 · 3 comments · Fixed by #17502
Assignees
@bartlomieju
Labels
bug Something isn't working correctly node compat node native extension related to the node-api (.node)

Comments

@bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju added bug Something isn't working correctly node compat node native extension related to the node-api (.node) labels Jan 11, 2023
@bartlomieju bartlomieju self-assigned this Jan 11, 2023
@bartlomieju bartlomieju mentioned this issue Jan 16, 2023
Open
@littledivy
Copy link
Member

It's not ignored. the C++ macro NODE_API_MODULE expands to the proper register function https://github.com/nodejs/node-addon-api/blob/fdc6263034cf8b16a4a61f9fef1b660494e1b280/napi-inl.h#L342-L345

@bartlomieju
Copy link
Member Author

I'm pretty sure we can't handle a case like this:
https://github.com/nodejs/node/blob/e48763840625c037282681456ecd1e1cb034f636/test/js-native-api/test_constructor/test_constructor.c#L161

Here's the relevant that handles this:
https://github.com/nodejs/node/blob/e48763840625c037282681456ecd1e1cb034f636/src/node_api.cc#L671-L678

@bartlomieju bartlomieju reopened this Jan 23, 2023
@littledivy littledivy mentioned this issue Jan 23, 2023
Merged
littledivy added a commit that referenced this issue Jan 23, 2023
@littledivy
fix(napi): handle return value from initializer (#17502)
c3e0b12 
Fixes #17349
@POPPIN-FUMI
Copy link

@littledivy Thank you for fixing this issue!
I am Kawasaki from EpicsDAO,
We empower open-source software development.
This quest is related to Epics Alpha's quest.
So you get 3000$EPCT as a reward if you submit this PR link to this platform
https://alpha.epics.dev/en/quest/UXVlc3Q6MTM2/

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
bug Something isn't working correctly node compat node native extension related to the node-api (.node)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(napi): handle return value from initializer littledivy/deno
3 participants
@bartlomieju @POPPIN-FUMI @littledivy