Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run microtasks if macrotask callback did not work. #18871

Closed
bartlomieju opened this issue Apr 27, 2023 · 0 comments · Fixed by #19492
Closed

Don't run microtasks if macrotask callback did not work. #18871

bartlomieju opened this issue Apr 27, 2023 · 0 comments · Fixed by #19492
Assignees
@bartlomieju
Labels
perf performance related

Comments

@bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju self-assigned this Apr 27, 2023
@bartlomieju bartlomieju mentioned this issue May 1, 2023
Closed
@aapoalas aapoalas added the perf performance related label May 6, 2023
@bartlomieju bartlomieju mentioned this issue Jun 14, 2023
Merged
bartlomieju added a commit that referenced this issue Jun 14, 2023
@bartlomieju
perf: don't run microtask checkpoint if macrotask callback did no work (
5ef2258 
#19492)

Most of the time there's no firing timers, nor pending promise
rejections, so it's wasteful to run microtask checkpoint 
additionally twice on each tick of the event loop.

Closes #18871
Ref #19451
bartlomieju added a commit that referenced this issue Jun 15, 2023
@bartlomieju
perf: don't run microtask checkpoint if macrotask callback did no work (
de82fa2 
#19492)

Most of the time there's no firing timers, nor pending promise
rejections, so it's wasteful to run microtask checkpoint 
additionally twice on each tick of the event loop.

Closes #18871
Ref #19451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
perf performance related
Projects
None yet
Milestone
No milestone
2 participants
@bartlomieju @aapoalas