Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"urllib" npm package compatibility (error in 1.33.4, success in 1.33.3) #19349

Closed
iugo opened this issue Jun 2, 2023 · 0 comments · Fixed by #19340
Closed

"urllib" npm package compatibility (error in 1.33.4, success in 1.33.3) #19349

iugo opened this issue Jun 2, 2023 · 0 comments · Fixed by #19340

Comments

@iugo
Copy link
Contributor

iugo commented Jun 2, 2023

code is:

import { request } from 'npm:urllib@2.40.0';

Deno.test('test', async () => {
  const { data, res } = await request('https://1.1.1.1/');
  console.log(data, res);
});

When deno upgrade --version 1.33.3, it can return successfully. But in deno upgrade --version 1.33.4 and later versions, an error will throw:

TypeError: Cannot read properties of null (reading '_URLLIB_SOCKET_RESPONSE_COUNT')
bartlomieju added a commit that referenced this issue Jun 6, 2023
Fixes #19349

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
bartlomieju added a commit that referenced this issue Jun 8, 2023
Fixes #19349

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant