Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode deno doesn't auto discover deno.json when its in a subdirectory #20210

Open
ry opened this issue Aug 19, 2023 · 4 comments
Open

vscode deno doesn't auto discover deno.json when its in a subdirectory #20210

ry opened this issue Aug 19, 2023 · 4 comments
Labels
lsp related to the language server suggestion suggestions for new features (yet to be agreed)

Comments

@ry
Copy link
Member

ry commented Aug 19, 2023

I have a mutli-language project structure where the deno.json is actually in a sub-directory. The lsp and/or vscode extension doesn't auto discover the deno.json which leads to red squiggles on my imports when using an import map.

Screenshot 2023-08-19 at 11 44 07 AM

By changing the .vscode/settings.json I can work around this:

{
  "rust-analyzer.cargo.features": [
    "e2e_tests"
  ],
  "deno.enable": true,
  "deno.config": "./drg/deno.json",
  "deno.enablePaths": ["./drg"]
}

However I expect many users will get stuck here.

I suggest that each time we see a TS or JS file we walk up the tree towards the root looking for deno.json.

Note: we don't support multiple config files yet denoland/vscode_deno#787

@ry ry added lsp related to the language server suggestion suggestions for new features (yet to be agreed) labels Aug 19, 2023
@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Sep 14, 2023

Subdirectory detection will probably be coupled with multi-root detection. Closing in favour of denoland/vscode_deno#787.

@nayeemrmn nayeemrmn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@CITIZENDOT
Copy link

How is #787 related to this issue?

@nayeemrmn
Copy link
Collaborator

How is #787 related to this issue?

Sorry, edited.

@nayeemrmn
Copy link
Collaborator

Actually let's keep this open alongside denoland/vscode_deno#787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp related to the language server suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

3 participants