Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno.noColor is true even if it's set to an empty string #21274

Closed
angelnext opened this issue Nov 20, 2023 · 0 comments · Fixed by #21275
Closed

Deno.noColor is true even if it's set to an empty string #21274

angelnext opened this issue Nov 20, 2023 · 0 comments · Fixed by #21275
Labels
bug Something isn't working correctly

Comments

@angelnext
Copy link

Deno.noColor says true even when it's set to an empty string, even thought the no-color website says that the NO_COLOR var has to be:

present and not an empty string (regardless of its value)
@dsherret dsherret mentioned this issue Nov 20, 2023
Merged
@dsherret dsherret added the bug Something isn't working correctly label Nov 20, 2023
dsherret added a commit that referenced this issue Nov 20, 2023
@dsherret
fix: Deno.noColor should not be true when NO_COLOR is empty string (#…
1eefe3e 
…21275)

Closes #21274
zifeo pushed a commit to metatypedev/deno that referenced this issue Nov 22, 2023
@dsherret @zifeo
fix: Deno.noColor should not be true when NO_COLOR is empty string (d…
6528c3c 
…enoland#21275)

Closes denoland#21274
crowlKats pushed a commit that referenced this issue Nov 24, 2023
@dsherret @crowlKats
fix: Deno.noColor should not be true when NO_COLOR is empty string (#…
1254874 
…21275)

Closes #21274

(cherry picked from commit 1eefe3e)
bartlomieju pushed a commit that referenced this issue Nov 24, 2023
@dsherret @bartlomieju
fix: Deno.noColor should not be true when NO_COLOR is empty string (#…
3b022f3 
…21275)

Closes #21274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Deno.noColor should not be true when NO_COLOR is empty string dsherret/deno
2 participants
@dsherret @angelnext