Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error running task when nodeModulesDir is set to true but the node_modules directory is absent #23914

Closed
0f-0b opened this issue May 21, 2024 · 0 comments · Fixed by #23920
Closed

Error running task when nodeModulesDir is set to true but the node_modules directory is absent #23914

0f-0b opened this issue May 21, 2024 · 0 comments · Fixed by #23920
Assignees
@dsherret
Labels
bug Something isn't working correctly task runner related to deno task

Comments

@0f-0b
Copy link
Contributor

0f-0b commented May 21, 2024 

$ echo '{ "nodeModulesDir": true, "tasks": { "repro": "true" } }' >deno.json
$ deno cache npm:react@18.3.1
$ rm -r node_modules
$ deno task repro
error: No such file or directory (os error 2)
$ deno --version
deno 1.43.5+c703ddd (canary, aarch64-apple-darwin)
v8 12.4.254.13
typescript 5.4.5
@dsherret dsherret added bug Something isn't working correctly task runner related to deno task labels May 21, 2024
@dsherret dsherret self-assigned this May 21, 2024
@dsherret dsherret mentioned this issue May 21, 2024
Merged
dsherret added a commit that referenced this issue May 21, 2024
@dsherret
fix(task): do not error if node_modules folder not exists (#23920)
9795637 
Revealed #23919

Closes #23914
bartlomieju pushed a commit that referenced this issue May 21, 2024
@dsherret @bartlomieju
fix(task): do not error if node_modules folder not exists (#23920)
61819c4 
Revealed #23919

Closes #23914
bartlomieju pushed a commit that referenced this issue May 21, 2024
@dsherret @bartlomieju
fix(task): do not error if node_modules folder not exists (#23920)
2af55d2 
Revealed #23919

Closes #23914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working correctly task runner related to deno task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(task): do not error if node_modules folder not exists dsherret/deno
2 participants
@dsherret @0f-0b