-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo check #1128
Merged
Merged
cargo check #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2018
Closed
i appear to be experiencing this recently reported bug on window https://bugs.chromium.org/p/chromium/issues/detail?id=801780#c55 |
ry
force-pushed
the
cargo_check
branch
5 times, most recently
from
October 31, 2018 15:40
f63ce12
to
225f077
Compare
ry
force-pushed
the
cargo_check
branch
2 times, most recently
from
October 31, 2018 15:44
f5cb2e6
to
c2a3a1f
Compare
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125 respectively. - TODO The DENO_BUILD_PATH env var must be supplied and must be an absolute path, this restriction should be removed in future work.
This commit also allows us to run |
piscisaureus
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please squash.
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (denoland#998) - Add deno.Buffer (denoland#1121) - Support cargo check (denoland#1128) - Upgrade Rust crates and Flatbuffers. (denoland#1145, denoland#1127) - Add helper to turn deno.Reader into async iterator (denoland#1130) - Add ability to load JSON as modules (denoland#1065) - Add deno.resources() (denoland#1119) - Add application/x-typescript mime type support (denoland#1111)
Merged
ry
added a commit
that referenced
this pull request
Nov 5, 2018
- Performance and stability improvements on all platforms. - Add repl (#998) - Add deno.Buffer (#1121) - Support cargo check (#1128) - Upgrade Rust crates and Flatbuffers. (#1145, #1127) - Add helper to turn deno.Reader into async iterator (#1130) - Add ability to load JSON as modules (#1065) - Add deno.resources() (#1119) - Add application/x-typescript mime type support (#1111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage