Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo check #1128

Merged
merged 6 commits into from
Oct 31, 2018
Merged

cargo check #1128

merged 6 commits into from
Oct 31, 2018

Conversation

ry
Copy link
Member

@ry ry commented Oct 31, 2018

usage

DENO_BUILD_PATH=`pwd`/out/debug cargo check

@ry
Copy link
Member Author

ry commented Oct 31, 2018

i appear to be experiencing this recently reported bug on window https://bugs.chromium.org/p/chromium/issues/detail?id=801780#c55

@ry ry force-pushed the cargo_check branch 5 times, most recently from f63ce12 to 225f077 Compare October 31, 2018 15:40
@ry ry requested a review from piscisaureus October 31, 2018 15:41
@ry ry force-pushed the cargo_check branch 2 times, most recently from f5cb2e6 to c2a3a1f Compare October 31, 2018 15:44
- Based on code from @qti3e and @piscisaureus in denoland#724 and denoland#1125
  respectively.
- TODO The DENO_BUILD_PATH env var must be supplied and must be an
  absolute path, this restriction should be removed in future work.
@ry
Copy link
Member Author

ry commented Oct 31, 2018

This commit also allows us to run cargo doc... I've uploaded a snapshot of what that looks like: https://deno.land/doc/deno/

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
BUILD.gn Outdated Show resolved Hide resolved
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash.

@ry ry merged commit 198e396 into denoland:master Oct 31, 2018
@ry ry deleted the cargo_check branch October 31, 2018 18:16
ry added a commit to ry/deno that referenced this pull request Nov 5, 2018
- Performance and stability improvements on all platforms.
- Add repl (denoland#998)
- Add deno.Buffer (denoland#1121)
- Support cargo check (denoland#1128)
- Upgrade Rust crates and Flatbuffers. (denoland#1145, denoland#1127)
- Add helper to turn deno.Reader into async iterator (denoland#1130)
- Add ability to load JSON as modules (denoland#1065)
- Add deno.resources() (denoland#1119)
- Add application/x-typescript mime type support (denoland#1111)
@ry ry mentioned this pull request Nov 5, 2018
ry added a commit that referenced this pull request Nov 5, 2018
- Performance and stability improvements on all platforms.
- Add repl (#998)
- Add deno.Buffer (#1121)
- Support cargo check (#1128)
- Upgrade Rust crates and Flatbuffers. (#1145, #1127)
- Add helper to turn deno.Reader into async iterator (#1130)
- Add ability to load JSON as modules (#1065)
- Add deno.resources() (#1119)
- Add application/x-typescript mime type support (#1111)
@ry ry mentioned this pull request Nov 25, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants